From: Nanako Shiraishi Date: Sun, 18 Oct 2009 10:34:43 GMT Subject: Re: [PATCH v3.1 3/5] Introduce new pretty formats %g[sdD] for reflog information Message-ID: <20091018193443.6117@nanako3.lavabit.com> In-Reply-To: <20091018071829.GA7748@coredump.intra.peff.net> Quoting Jeff King > On Sat, Oct 17, 2009 at 04:48:11PM +0200, Thomas Rast wrote: > >> > +NOTE: Some placeholders may depend on other options given to the >> > +revision traversal engine. For example, the `%g*` reflog options will >> > +insert an empty string unless we are traversing reflog entries (e.g., by >> > +`git log -g`). The `%d` placeholder will use the "short" decoration >> > +format if `--decorate` was not already provided on the command line. >> >> Sure. I figured it was obvious enough, but since you already went to >> the lengths of documenting the exact behaviour of %d, I squashed it >> and adjusted the acknowledgement in the commit message accordingly. > > If the consensus (or Junio's decision when applying) is that we don't > need it, I don't mind if my suggestion is scrapped (or reworded). I think your clarification is a good addition. -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/