From: Shawn O. Pearce <spearce@spearce.org>
Date: Tue, 13 Oct 2009 18:24:27 GMT
Subject: Re: [RFC PATCH v2 12/16] Smart fetch and push over HTTP: server side
Message-ID: <20091013182427.GA9261@spearce.org>
In-Reply-To: <4AD42C87.6000205@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> wrote:
> Shawn O. Pearce schrieb:
> > diff --git a/http-backend.c b/http-backend.c
> 
> #include "run-command.h" is missing here because you added it already in
> patch 10/16 unnecessarily.
> 
> > +	if (start_command(&cld))
> > +		die_errno("Cannot start %s", argv[0]);
> > ...
> > +	if (finish_command(&cld))
> > +		die("%s terminated with error", argv[0]);
> 
> start_command and finish_command already write an error message for you
> that includes argv[0] and errno. You can just exit(1) here.

Whoops on both; thanks for the catch.

-- 
Shawn.