From: Shawn O. Pearce Date: Fri, 09 Oct 2009 14:29:50 GMT Subject: Re: [PATCHv2 2/2] completion: fix alias listings with newlines Message-ID: <20091009142950.GS9261@spearce.org> In-Reply-To: <1255069304-8953-2-git-send-email-bebarino@gmail.com> Stephen Boyd wrote: > Aliases with newlines have been a problem since commit 56fc25f (Bash > completion support for remotes in .git/config., 2006-11-05). The chance > of the problem occurring has been slim at best, until commit 518ef8f > (completion: Replace config --list with --get-regexp, 2009-09-11) > removed the case statement introduced by commit 56fc25f. Before removing > the case statement, most aliases with newlines would work unless they > were specially crafted as follows ... > Hannes has convinced me to go this route. I don't really see a problem, it > basically reverts to broken behavior that nobody's complained about in 3 > years. At least it's less broken? Yay. Given that we have no better solution easily available, I like the idea of just reverting to the behavior we have had for the past 3 years. Thanks. Acked-by: Shawn O. Pearce -- Shawn.