From: Petter Urkedal Date: Mon, 05 Oct 2009 06:36:49 GMT Subject: Re: [PATCH] Reserve a slot for argv[0] in default_arg. Message-ID: <20091005063649.GA25040@eideticdew.org> In-Reply-To: <7v4oqen6my.fsf@alter.siamese.dyndns.org> On 2009-10-04, Junio C Hamano wrote: > It is a command specific aliasing mechanism; not even I use the feature > these days, since "alias.*" is much easier to use. But there is no strong > need to remove it either; it is not too much hassle to keep it for people > who do use it. Perhaps deprecate it and remove it in the long run? I didn't know about alias.*. Excellent. I'll be using that. > > Correct. Junio sent a patch to fix this problem in June[1]. I guess he > > must have dropped his own patch, or he wasn't satisfied with how parse > > options clobbers things. > > > > [1] http://article.gmane.org/gmane.comp.version-control.git/121142 > > I had it kept still in my Inbox; thanks for noticing. Petter's patch does > essentially the same thing, but the old patch had a better log message > that described where in the history the fix should apply, so I'd probably > use that with your test squashed in. The code is slightly nicer to, I think, but you can probably drop "+ 20" in the grow-case now.