From: Jeff King <peff@peff.net>
Date: Fri, 02 Oct 2009 00:43:25 GMT
Subject: Re: [PATCH 2/2] add NORETURN_PTR for function pointers
Message-ID: <20091002004325.GA506@coredump.intra.peff.net>
In-Reply-To: <40aa078e0910010957q4daf104cja218af3aa5424637@mail.gmail.com>

On Thu, Oct 01, 2009 at 09:57:12AM -0700, Erik Faye-Lund wrote:

> On Thu, Oct 1, 2009 at 1:17 AM, Jeff King <peff@peff.net> wrote:
> > Thanks, this version and (your 1/2) both look sane to me. The only thing
> > missing are some Makefile knobs to tweak this, but I will assume that
> > will come as part of a later MSVC-compatibility series.
> 
> Thanks for reviewing :)
> 
> I sent an additional patch to the msysgit mailing-list that defines
> NORETURN for MSVC, but I think it's better to keep it out of git.git
> for a little while. There's no Makefile-knobs, it checks for _MSC_VER
> (similar to what's done for GCC).

That sounds good. Thanks.

-Peff