From: Jeff King <peff@peff.net>
Date: Thu, 01 Oct 2009 03:11:40 GMT
Subject: Re: [PATCH] gitweb: Do not show 'patch' link in 'commit' view for merges
Message-ID: <20091001031140.GA30094@coredump.intra.peff.net>
In-Reply-To: <20090930201953.22301.73887.stgit@localhost.localdomain>

On Wed, Sep 30, 2009 at 10:21:53PM +0200, Jakub Narebski wrote:

> Show 'patch' link in the 'commit' view only for commits which have
> exactly one parent, otherwise call to git-format-patch would fail for
> the hyperlinked 'patch' action.

Fail in what way? From my cursory reading of the code, it looks like the
'patch' action calls into git_commitdiff, which handles the multi-parent
case.

I assume I'm reading wrong, since you obviously know gitweb much better
than I do. :) But can you expand a little on the nature of the problem
in the commit message?

-Peff