From: Eric Wong <normalperson@yhbt.net>
Date: Wed, 30 Sep 2009 20:55:01 GMT
Subject: Re: [PATCH v2] send-email: fix mutt regex for grouped aliases
Message-ID: <20090930205501.GA30910@dcvr.yhbt.net>
In-Reply-To: <1254322176-4561-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> wrote:
> For example:
> alias -group friends foo Foo Bar <foo@bar.com>
> 
> Comments by Jeff King.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

Interesting, I didn't know about this feature in mutt before.

Acked(-and-tested)-by: Eric Wong <normalperson@yhbt.net>

> ---
>  git-send-email.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 0700d80..93b7ed2 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -401,7 +401,7 @@ my %aliases;
>  my %parse_alias = (
>  	# multiline formats can be supported in the future
>  	mutt => sub { my $fh = shift; while (<$fh>) {
> -		if (/^\s*alias\s+(\S+)\s+(.*)$/) {
> +		if (/^\s*alias\s+(?:-group\s+\S+\s+)*(\S+)\s+(.*)$/) {
>  			my ($alias, $addr) = ($1, $2);
>  			$addr =~ s/#.*$//; # mutt allows # comments
>  			 # commas delimit multiple addresses
> --