From: Johan Herland <johan@herland.net>
Date: Thu, 17 Sep 2009 07:13:03 GMT
Subject: Re: [RFC/PATCH v2] fetch: Speed up fetch by rewriting find_non_local_tags
Message-ID: <200909170913.03639.johan@herland.net>
In-Reply-To: <alpine.LNX.2.00.0909170227160.15719@reaper.quantumfyre.co.uk>

On Thursday 17 September 2009, Julian Phillips wrote:
> On Thu, 17 Sep 2009, Julian Phillips wrote:
> > On Wed, 16 Sep 2009, Junio C Hamano wrote:
> >>  I am just curious.  How would a "just one item lookbehind" code
> >> perform compared to this one?
> >
> > The code you wrote ealier is almost the same as the string_list
> > version, ~ 4.3s, so very marginally slower but a lot less code change. 
> > Personally I'd be happy with any of the three, so long as I don't have
> > to wait 30s to find out that nothing's happened at $dayjob anymore ;)
> 
> FWIW: I've Just modified my v2 patch to make use of the requirement that
> the peeled ref immediately follow the base ref, and it's now ~4.1s and
> should use less memory than the original too.  I won't bother posting it
> unless someone thinks it worth it though.

It's worth it. :)


...Johan


-- 
Johan Herland, <johan@herland.net>
www.herland.net