From: Todd Zullinger <tmz@pobox.com>
Date: Sun, 13 Sep 2009 18:29:37 GMT
Subject: Re: [PATCH] completion: Replace config --list with --get-regexp
Message-ID: <20090913182937.GR2582@inocybe.localdomain>
In-Reply-To: <36ca99e90909130351m7ad5a641t8adb3ade3d2ec5ca@mail.gmail.com>

Bert Wesarg wrote:
> I have not looked into this, but what about pushurl?

Is it reasonable to expect someone to have remote.<name>.pushurl and
not have remote.<name>.url set?  If not, then we should be fine, as
all the old code and this new code do is extract <name>.

OTOH, if there are some cases where setting pushurl and not url make
sense, extending the regex to catch pushurl as well is a simple matter
of changing 'remote\..*\.url' to 'remote\..*\.(push)?url' and, I
believe, using 'echo "${i/.*url*/}"' to strip off everything after the
remote <name>.

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fleas can be taught nearly anything that a Congressman can.
    -- Mark Twain