From: Johan Herland <johan@herland.net>
Date: Sat, 12 Sep 2009 22:21:38 GMT
Subject: Re: [PATCHv6 10/14] Teach notes code to free its internal data structures on request.
Message-ID: <200909130021.38296.johan@herland.net>
In-Reply-To: <7vmy50f1mf.fsf@alter.siamese.dyndns.org>

On Saturday 12 September 2009, Junio C Hamano wrote:
> Johan Herland <johan@herland.net> writes:
> > There's no need to be rude to memory-concious callers...
> 
> Will squash this in.
> 
> -- >8 --
> From: Junio C Hamano <gitster@pobox.com>
> Date: Sat, 12 Sep 2009 11:34:24 -0700
> Subject: [PATCH] notes.[ch] fixup: avoid old-style declaration
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  notes.c |    2 +-
>  notes.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/notes.c b/notes.c
> index 008c3d4..9ed2c87 100644
> --- a/notes.c
> +++ b/notes.c
> @@ -161,7 +161,7 @@ void get_commit_notes(const struct commit *commit,
>  struct strbuf *sb, free(msg);
>  }
> 
> -void free_commit_notes()
> +void free_commit_notes(void)
>  {
>  	free(hash_map.entries);
>  	memset(&hash_map, 0, sizeof(struct hash_map));
> diff --git a/notes.h b/notes.h
> index 41802e5..d1dd1d1 100644
> --- a/notes.h
> +++ b/notes.h
> @@ -7,6 +7,6 @@
>  void get_commit_notes(const struct commit *commit, struct strbuf *sb,
>  		const char *output_encoding, int flags);
> 
> -void free_commit_notes();
> +void free_commit_notes(void);
> 
>  #endif

Thanks,

Acked-by: Johan Herland <johan@herland.net>


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net