From: Lars Noschinski <lars@public.noschinski.de>
Date: Tue, 08 Sep 2009 09:20:59 GMT
Subject: Re: [PATCH] post-receive-email: do not call sendmail if no mail was generated
Message-ID: <20090908092059.GA8207@lars.home.noschinski.de>
In-Reply-To: <1251481187-6361-1-git-send-email-lars@public.noschinski.de>

* Lars Noschinski <lars@public.noschinski.de> [09-08-28 19:39]:
> contrib/hooks/post-receive-email used to call the send_mail function
> (and thus, /usr/sbin/sendmail), even if generate_mail returned an error.
> This is problematic, as the sendmail binary provided by exim4 generates
> an error mail if provided with an empty input.
> 
> Therefore, this commit changes post-receive-email to only call sendmail
> if generate_mail returned without error.
> 
> Signed-off-by: Lars Noschinski <lars@public.noschinski.de>

Is anything wrong with this patch? Or is it just queued to be committed
some time?

 - Lars.