From: Jeff King <peff@peff.net>
Date: Sun, 30 Aug 2009 07:36:19 GMT
Subject: Re: [PATCH 1/2] Add date formatting and parsing functions relative to a given time
Message-ID: <20090830073619.GA14217@coredump.intra.peff.net>
In-Reply-To: <20090828210404.GA11867@blimp.localdomain>

On Fri, Aug 28, 2009 at 11:04:04PM +0200, Alex Riesen wrote:

> +const char *show_date_relative(unsigned long time, int tz, const struct timeval *now)
> +{
> +	static char timebuf[100 /* TODO: can be optimized */];

This was 200 in the original version. I doubt that it makes a
difference, but I think in a refactoring patch I think it is best to
simply reorganize and make no other changes.

> +static unsigned long approximation(const char *date, const struct timeval *tv)

I know it's static, but this is a terribly undescriptive function name.
Approximation of what?  Can we call it approxidate_internal or
something?

-Peff