From: Jeff King <peff@peff.net>
Date: Tue, 18 Aug 2009 23:35:35 GMT
Subject: Re: [PATCH 3/3] stash: reject stash name starting with a dash.
Message-ID: <20090818233535.GB6304@sigill.intra.peff.net>
In-Reply-To: <1250631523-10524-4-git-send-email-Matthieu.Moy@imag.fr>

On Tue, Aug 18, 2009 at 11:38:43PM +0200, Matthieu Moy wrote:

> This avoids typos like 'git stash save --invalid-option', particularly
> nasty since one can omit the 'save' subcommand. The syntax
> 'git stash save -- "-name starting with dash" still allows such stash name.

Aside from the documentation and usage lines, this one is actually
independent of the other two, and I think makes sense regardless of what
happens.

> +test_expect_success 'stash --invalid-option' '
> +       echo bar5 > file &&
> +       echo bar6 > file2 &&
> +       git add file2 &&
> +       ! git stash --invalid-option &&
> +       test bar5,bar6 = $(cat file),$(cat file2) &&
> +       git stash -- -message-starting-with-dash &&
> +       test bar,bar2 = $(cat file),$(cat file2)
> +'

Should this actually be "git stash save --invalid-option", since it is
really testing the actual save option parsing, and not the behavior to
automatically push options to "git stash save"?

Other than that, patch looks good.

-Peff