From: Emmanuel Trillaud Date: Sat, 08 Aug 2009 20:07:39 GMT Subject: Re: [PATCH 4/9] add missing long option to 'git grep' bash competion Message-ID: <20090808220739.663bb1f7@eleanor> In-Reply-To: <7vskg2dr3o.fsf@alter.siamese.dyndns.org> > > according to the 'git-grep' man page, the following long options are > > missing from the 'git grep' bash completion : > > --null > > --color > > --no-color > > I do not think completion's purpose should be to offer everything > available under the sun, so "according to manpage these are missing" can > never be a good justification for patches in this series. When I saw that completion for the long options of 'git checkout' was mising, I just start looking around the docs to see if there wasn't other git commands with some missing completions. I see now it was a wrong way to update the git bash completion. I will soon come back with a new set of (more reasonnable) patches. Emmanuel