From: Johan Herland <johan@herland.net>
Date: Thu, 30 Jul 2009 01:29:48 GMT
Subject: Re: [PATCHv3 7/8] fast-import: Add support for importing commit notes
Message-ID: <200907300329.48585.johan@herland.net>
In-Reply-To: <20090729142121.GB1033@spearce.org>

On Wednesday 29 July 2009, Shawn O. Pearce wrote:
> Johan Herland <johan@herland.net> wrote:
> > +static void note_change_n(struct branch *b)
> > +{
>
> ...
>
> > +	tree_content_set(&b->branch_tree, sha1_to_hex(commit_sha1), sha1,
> > +		S_IFREG | 0644, NULL);
>
> I thought you wanted to use the note code to handle the name
> formatting here?

Yes, I do, as soon as the notes code knows how to format/write note names 
(which I plan to tackle after nailing the _reading_ part of the code).


Have fun! :)

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net