From: Johan Herland <johan@herland.net>
Date: Thu, 30 Jul 2009 01:02:48 GMT
Subject: Re: [PATCHv3 5/8] Teach "-m <msg>" and "-F <file>" to "git notes edit"
Message-ID: <200907300302.48337.johan@herland.net>
In-Reply-To: <200907290957.36000.trast@student.ethz.ch>

On Wednesday 29 July 2009, Thomas Rast wrote:
> Johan Herland wrote:
> > diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
>
> [...]
>
> > +cat > expect-m-and-F << EOF
> > +commit 15023535574ded8b1a89052b32673f84cf9582b8
> > +Author: A U Thor <author@example.com>
> > +Date:   Thu Apr 7 15:16:13 2005 -0700
> > +
> > +    4th
> > +
> > +Notes:
> > +    spam
> > +
> > +    xyzzy
> > +
> > +    foo
>
> There's significant trailing whitespace here (in the lines between
> spam, xyzzy and foo) that initially broke the test for me because I
> use apply.whitespace=fix.  Can you guard the whitespace if it is
> really important, with something like
>
> sed 's/#$//' > expect <<EOF
> whitespace:    #
> EOF

Thanks! Will be fixed in the next iteration of this topic.


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net