From: Johan Herland <johan@herland.net>
Date: Thu, 30 Jul 2009 00:42:38 GMT
Subject: Re: [PATCHv3 1/8] Introduce commit notes
Message-ID: <200907300242.38844.johan@herland.net>
In-Reply-To: <81b0412b0907290152w27c1b5b5l9efbd6980d4f904e@mail.gmail.com>

On Wednesday 29 July 2009, Alex Riesen wrote:
> On Wed, Jul 29, 2009 at 04:25, Johan Herland<johan@herland.net> wrote:
> > +void get_commit_notes(const struct commit *commit, struct strbuf *sb,
> > +               const char *output_encoding)
> > +{
> > +       static const char *utf8 = "utf-8";
>
> Using an array
>
>   const char utf8[] = "utf-8";
>
> costs you less BSS (no separate storage for the pointer).

Thanks, will be fixed in the next iteration of this topic.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net