From: Thomas Rast <trast@student.ethz.ch>
Date: Wed, 29 Jul 2009 07:57:34 GMT
Subject: Re: [PATCHv3 5/8] Teach "-m <msg>" and "-F <file>" to "git notes edit"
Message-ID: <200907290957.36000.trast@student.ethz.ch>
In-Reply-To: <1248834326-31488-6-git-send-email-johan@herland.net>

Johan Herland wrote:
> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
[...]
> +cat > expect-m-and-F << EOF
> +commit 15023535574ded8b1a89052b32673f84cf9582b8
> +Author: A U Thor <author@example.com>
> +Date:   Thu Apr 7 15:16:13 2005 -0700
> +
> +    4th
> +
> +Notes:
> +    spam
> +    
> +    xyzzy
> +    
> +    foo

There's significant trailing whitespace here (in the lines between
spam, xyzzy and foo) that initially broke the test for me because I
use apply.whitespace=fix.  Can you guard the whitespace if it is
really important, with something like

sed 's/#$//' > expect <<EOF
whitespace:    #
EOF

Thanks!

-- 
Thomas Rast
trast@{inf,student}.ethz.ch