From: Jeff King Date: Fri, 24 Jul 2009 05:41:45 GMT Subject: Re: [PATCH/RFC] SunOS grep does not understand -C Message-ID: <20090724054144.GC6563@sigill.intra.peff.net> In-Reply-To: <7vr5w6tzq8.fsf@alter.siamese.dyndns.org> On Thu, Jul 23, 2009 at 10:30:07PM -0700, Junio C Hamano wrote: > I noticed that the first "grep -C1" test in t7002 does not pass on my > SunOS-5.11-i86pc, and that is not because our way to spawn external > grep is broken, but because the native grep does not understand -C. > > Is it just me and my installation (i.e. I might have failed to install > saner grep from the distribution that everybody uses), or everybody on > SunOS is using this option himself because our Makefile doesn't do that > automatically for them? > > Just in case it is the latter, here is a proposed patch. Yes, I've been building with NO_EXTERNAL_GREP for my test box. The grep from Solaris 8, at least, doesn't understand '-e' either, which causes it to fail many other tests. -Peff