From: Jeff King Date: Thu, 23 Jul 2009 05:07:11 GMT Subject: Re: [PATCH 2/3] refactor: use bitsizeof() instead of 8 * sizeof() Message-ID: <20090723050711.GB9189@coredump.intra.peff.net> In-Reply-To: <1248298475-2990-3-git-send-email-madcoder@debian.org> On Wed, Jul 22, 2009 at 11:34:34PM +0200, Pierre Habouzit wrote: > #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0])) > +#define bitsizeof(x) (CHAR_BIT * sizeof(x)) Isn't our style to use all-caps for macros? I.e., BITSIZEOF? -Peff