From: Nicolas Sebrecht Date: Fri, 17 Jul 2009 22:04:24 GMT Subject: [PATCH v6] Re: mailinfo: allow e-mail files as input Message-ID: <20090717220424.GA12968@vidovic> In-Reply-To: <7vtz1b3x26.fsf@alter.siamese.dyndns.org> The 17/07/09, Junio C Hamano wrote: > Nanako Shiraishi writes: > > > Why does this description have ... in it? If I'm reading it correctly, the code in check_patch_format function checks only the first file. ( Please, wrap your lines to something convenient. ) > Good eyes. > > This actually is an issue with the Guiseppe's multi-format support patch > in that we assume that the command line input are of uniform type, check > only $1 and assume $2 and subsequent are suitable to be fed to the same > splitter. > > I do not think it is necessary to allow mixed input. We certainly could, > but why bother? It is not a sensible nor common thing to do. I agree. > Also the documentation said we take only one mbox or multiple Maildirs, > but in reality we can take multiple mboxes just fine, so should > have had "..." at the end (we could lose the ellipses from all of them for > brevity). Oh, and it should list the other formats Giuseppe added. > > ||:: > > One or more of the same type of mail source to read e-mails > from. A directory is taken as a mailbox in the maildir > format. A file is taken as UNIX mbox, StGit patch series > file, or a single piece of e-mail in RFC2822 format. Strictly speacking, this is not what I understand from the code: only one StGit patch series can be given at the command line. |||:: One or more of the same type of mail source to read e-mails from. A directory is taken as a mailbox in the maildir format. A file is taken as UNIX mbox, StGit patch file, or a single piece of e-mail in RFC2822 format. StGit patches series are also supported but only one series at a time. -- Nicolas Sebrecht