From: Johan Herland Date: Thu, 09 Jul 2009 14:42:05 GMT Subject: Re: [PATCH v3] quickfetch(): Prevent overflow of the rev-list command line Message-ID: <200907091642.05746.johan@herland.net> In-Reply-To: <4A55FCD5.2020908@viscovery.net> On Thursday 09 July 2009, Johannes Sixt wrote: > But actually I meant you to make a test that triggers the SIGPIPE that > would kill git-fetch if it were not ignored. This one doesn't trigger it, > either. AFAIU from earlier in this thread (and a mail from Peter linking to http://markmail.org/message/dbgdj4csafen65ye), SIGPIPE _never_ triggers on Windows, thus ignoring SIGPIPE is not needed for the fix per se. However, as a side-effect of the fix, we may now get SIGPIPE on Linux (and other POSIX platforms), so although it never triggers on Windows, it's still needed. ...Johan -- Johan Herland, www.herland.net