From: Johan Herland <johan@herland.net>
Date: Thu, 09 Jul 2009 09:07:46 GMT
Subject: Re: [PATCH] quickfetch(): Prevent overflow of the rev-list command line
Message-ID: <200907091107.46838.johan@herland.net>
In-Reply-To: <4A55AF88.3090205@viscovery.net>

On Thursday 09 July 2009, Johannes Sixt wrote:
> Johan Herland schrieb:
> > Does anybody with Windows/MSYS experience know how this scenario
> > (write() to a terminated process, followed by close()) would play out
> > in msysGit?
>
> The first write() sometimes fails with EPIPE, otherwise it fails with
> EINVAL. All subsequent write()s fail with EINVAL. The setting of SIGPIPE
> is irrelevant because it is unknown to Windows.
>
> There's precedent already in write_or_die.c. You should not write the
> error message for both EPIPE and EINVAL.

Thanks, but what about the subsequent close()? Will it fail with EINVAL? 
EBADF? or will is succeed (like on Linux)?

I will send an updated patch with all fixes, as soon as I know what to do 
about close().


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net