From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 05 Jul 2009 19:01:13 GMT
Subject: Re: [PATCH 4/7] run_command: report system call errors instead of returning error codes
Message-ID: <200907052101.13741.j6t@kdbg.org>
In-Reply-To: <ea2d8110ea70b8698bb3674ca4482db64053d841.1246734159.git.j6t@kdbg.org>

On Samstag, 4. Juli 2009, Johannes Sixt wrote:
> +	if (status >= 0 || errno != ENOENT)
> +		exit(status & 0xff);

With my replacement patch 1/7 this '& 0xff' is no longer necessary. Would you
kindly squash this in?

-- Hannes

diff --git a/git.c b/git.c
--- a/git.c
+++ b/git.c
@@ -418,7 +418,7 @@ static void execv_dashed_external(const char **argv)
 	 */
 	status = run_command_v_opt(argv, RUN_SILENT_EXEC_FAILURE);
 	if (status >= 0 || errno != ENOENT)
-		exit(status & 0xff);
+		exit(status);
 
 	argv[0] = tmp;