From: Jeff King Date: Wed, 01 Jul 2009 07:26:28 GMT Subject: [PATCH 1/2] log-tree: fix confusing comment Message-ID: <20090701072628.GA8101@sigio.peff.net> In-Reply-To: <20090701070252.GA7987@sigio.peff.net> This comment mentions the case where use_terminator is set, but this case is not handled at all by this chunk of code. Signed-off-by: Jeff King --- This comment confused me quite a bit while tracking down the issue in 2/2. log-tree.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/log-tree.c b/log-tree.c index 59d63eb..6f73c17 100644 --- a/log-tree.c +++ b/log-tree.c @@ -321,7 +321,8 @@ void show_log(struct rev_info *opt) } /* - * If use_terminator is set, add a newline at the end of the entry. + * If use_terminator is set, we already handled any record termination + * at the end of the last record. * Otherwise, add a diffopt.line_termination character before all * entries but the first. (IOW, as a separator between entries) */ -- 1.6.3.3.485.g0f5d4.dirty