From: Johannes Sixt <j6t@kdbg.org>
Date: Tue, 30 Jun 2009 20:31:45 GMT
Subject: run_hook: why special check for uncaught signal?
Message-ID: <200906302231.45157.j6t@kdbg.org>

Function run_hook (in run-command.c) has this check:

	ret = finish_command(&hook);
	if (ret == -ERR_RUN_COMMAND_WAITPID_SIGNAL)
		warning("%s exited due to uncaught signal", argv[0]);
	return ret;

The lines were moved to this location by ae98a008 (Move run_hook() from 
builtin-commit.c into run-command.c (libgit), 2009-01-16). Before this 
commit, the check existed in builtin-gc.c. It was introduced by bde30540 
(git-gc --auto: add pre-auto-gc hook, 2008-04-09).

Why is this check necessary?

I'm asking because I'm working on a modification that would remove 
ERR_RUN_COMMAND_WAITPID_SIGNAL.

-- Hannes