From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 30 Jun 2009 20:10:09 GMT
Subject: Re: [PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too
Message-ID: <200906302210.10280.jnareb@gmail.com>
In-Reply-To: <1246312854-3365-4-git-send-email-giuseppe.bilotta@gmail.com>

On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:

> parse_tag must be adapted to use the hash keys expected by
> git_print_authorship_rows. This is not a problem since git_tag is the
> only user of this sub.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

Very nice unification (of hash key names for parse_tag and
parse_commit_text), and nice refactoring of common code.

Acked-by: Jakub Narebski <jnareb@gmail.com>

[...]
> @@ -2409,8 +2409,14 @@ sub parse_tag {
>  			$tag{'name'} = $1;
>  		} elsif ($line =~ m/^tagger (.*) ([0-9]+) (.*)$/) {
>  			$tag{'author'} = $1;
> -			$tag{'epoch'} = $2;
> -			$tag{'tz'} = $3;
> +			$tag{'author_epoch'} = $2;
> +			$tag{'author_tz'} = $3;
> +			if ($tag{'author'} =~ m/^([^<]+) <([^>]*)>/) {
> +				$tag{'author_name'}  = $1;
> +				$tag{'author_email'} = $2;
> +			} else {
> +				$tag{'author_name'} = $tag{'author'};
> +			}

Unrelated sidenote: I wonder if it would work correctly on
malformed 'tagger' headers which sometimes happen... Probably
not.  But this is not an issue with this patch, but with gitweb
in general.

-- 
Jakub Narebski
Poland