From: Christian Couder <chriscool@tuxfamily.org>
Date: Sun, 21 Jun 2009 05:15:36 GMT
Subject: Re: [PATCH 2/2] rebase -i: use some kind of config file to save author information
Message-ID: <200906210715.36965.chriscool@tuxfamily.org>
In-Reply-To: <m3ab43gsrm.fsf@localhost.localdomain>

On Saturday 20 June 2009, Jakub Narebski wrote:
> Christian Couder <chriscool@tuxfamily.org> writes:
> > Subject: [PATCH 2/2] rebase -i: use some kind of config file to save
> > author information
>
> Errr... "kind of" config file?  I'd say use config file format for
> saving author information.

Ok, I changed this in the patch series I just sent.

> > This is better than saving in a shell script, because it will make
> > it much easier to port "rebase -i" to C. This also removes some sed
> > regexps and some "eval"s.
>
> Would it?  Well, I guess that at least we will avoid problems with
> shell quoting and shell variable expansion rules.

Yeah.

> > +load_author_ident () {
> > +	GIT_AUTHOR_NAME=$(GIT_CONFIG="$SAVE_AUTHOR_INFO" \
> > +		git config rebase.author.name) &&
> > +	GIT_AUTHOR_EMAIL=$(GIT_CONFIG="$SAVE_AUTHOR_INFO" \
> > +		git config rebase.author.mail) &&
> > +	GIT_AUTHOR_DATE=$(GIT_CONFIG="$SAVE_AUTHOR_INFO" \
> > +		git config rebase.author.date)
> >  }
>
> Why not use --file=<filename> option of git-config instead?

That's a good idea. I changed that too.

Thanks,
Christian.