From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed, 10 Jun 2009 14:16:14 GMT
Subject: Re: [PATCH 1/2] more tests for git rev-parse --parse-opt
Message-ID: <20090610141614.GA20299@pengutronix.de>
In-Reply-To: <4A2F8CEC.4080600@viscovery.net>

Hello Johannes,

On Wed, Jun 10, 2009 at 12:37:32PM +0200, Johannes Sixt wrote:
> Uwe Kleine-König schrieb:
> > -test_expect_success 'test --parseopt help output' '
> > -	git rev-parse --parseopt -- -h 2> output.err <<EOF
> > +OPTION_SPEC="\
> >  some-command [options] <args>...
> >  
> >  some-command does foo and bar!
> > @@ -36,8 +35,53 @@ C?        option C with an optional argument
> >  
> >  Extras
> >  extra1    line above used to cause a segfault but no longer does
> > +"
> > +
> > +test_expect_success 'test --parseopt help output' '
> > +	git rev-parse --parseopt -- -h 2> output.err <<EOF
> > +$OPTION_SPEC
> >  EOF
> >  	test_cmp expect.err output.err
> >  '
> 
> You use the same input in this and all new tests; make this:
> 
> cat > optionspec <<EOF
> ...
> EOF
> 
> test_expect_success 'test --parseopt help output' '
> 	git rev-parse --parseopt -- -h 2> output.err < optionspec &&
> 	test_cmp expect.err output.err
> 
> (note the added &&).
OK, this should work.  I will rework it later today.

BTW: I wonder why

	git rev-parse --parseopt -- -h 2> output.err < optionspec

fills output.err, is there some magic that detects that the help should
be printed?  *read some source*  ah, -h is hardcoded to print the help.
This is a bit surprising, still more as -h is a valid option in the
specified optionspec.  Thoughts?

Thanks
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |