From: Pierre Habouzit <madcoder@madism.org>
Date: Tue, 09 Jun 2009 08:06:13 GMT
Subject: Re: [PATCH] show-branch: fix segfault when showbranch.default exists
Message-ID: <20090609080612.GG9993@laphroaig.corp>
In-Reply-To: <4A2E0C88.70805@gmail.com>

On Tue, Jun 09, 2009 at 12:17:28AM -0700, Stephen Boyd wrote:
> Junio C Hamano wrote:
> > I am not sure if this is a bug in parse_options(), or a bug in the caller,
> > and tonight I do not have enough concentration to figure out which.  In
> > any case, this patch works the issue around.
> 
> I am low on concentration tonight as well, but this looks right to me.
> Parse options is expecting the regular old argv and argc. I overlooked
> this code path during the conversion (though I remember figuring out
> what this path was doing). Faking the argv and argc a little more
> accurately, like you do, should work fine.

yes, that's it.
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org