From: Markus Heidelberg Date: Mon, 08 Jun 2009 07:13:16 GMT Subject: [PATCH v3 4/6] add a test for git-send-email for non-threaded mails Message-ID: <200906080913.16894.markus.heidelberg@web.de> In-Reply-To: <7vd49f8b1f.fsf@alter.siamese.dyndns.org> Signed-off-by: Markus Heidelberg --- Junio C Hamano, 08.06.2009: > Generally, we protect "git" (i.e. what we write ourselves) with test_must_fail > so that we can catch stupid segfaulting crash we introduce ourselves > (unlike "! git foo", "test_must_fail git foo" says "oh, no, it did not > correctly fail" if git segfaults). We do not expect "grep" to segfault > (iow we are not testing "grep"), so it is customary to say "! grep". Thanks for the explanation. Differences to v2: * "! grep" instead of "test_must_fail grep" t/t9001-send-email.sh | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 990dd1a..20efdc1 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -621,6 +621,16 @@ test_expect_success 'in-reply-to but no threading' ' grep "In-Reply-To: " ' +test_expect_failure 'no in-reply-to and no threading' ' + git send-email \ + --dry-run \ + --from="Example " \ + --to=nobody@example.com \ + --nothread \ + $patches $patches >stdout && + ! grep "In-Reply-To: " stdout +' + test_expect_success 'threading but no chain-reply-to' ' git send-email \ --dry-run \ -- 1.6.3.2.224.gaa543