From: Markus Heidelberg Date: Mon, 08 Jun 2009 06:41:59 GMT Subject: Re: [PATCH v2 4/6] add a test for git-send-email for non-threaded mails Message-ID: <200906080842.00357.markus.heidelberg@web.de> In-Reply-To: <1244410857-920-5-git-send-email-markus.heidelberg@web.de> Signed-off-by: Markus Heidelberg --- Differences to v1: * dump stdout into a file and grep this * use "test_must_fail grep" instead of "!git send-email" I'm not sure about this. When should test_must_fail be used and when is !command OK? t/t9001-send-email.sh | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 990dd1a..4a4fa7f 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -621,6 +621,16 @@ test_expect_success 'in-reply-to but no threading' ' grep "In-Reply-To: " ' +test_expect_failure 'no in-reply-to and no threading' ' + git send-email \ + --dry-run \ + --from="Example " \ + --to=nobody@example.com \ + --nothread \ + $patches $patches >stdout && + test_must_fail grep "In-Reply-To: " stdout +' + test_expect_success 'threading but no chain-reply-to' ' git send-email \ --dry-run \ -- 1.6.3.2.220.gb421