From: Markus Heidelberg Date: Mon, 08 Jun 2009 06:37:31 GMT Subject: [PATCH v2 2/6] add a test for git-send-email for threaded mails without chain-reply-to Message-ID: <200906080837.31548.markus.heidelberg@web.de> In-Reply-To: <200906080747.18233.markus.heidelberg@web.de> Signed-off-by: Markus Heidelberg --- Markus Heidelberg, 08.06.2009: > Junio C Hamano, 08.06.2009: > > Markus Heidelberg writes: > > > > > +test_expect_failure 'threading but no chain-reply-to' ' > > > + git send-email \ > > > + --dry-run \ > > > + --from="Example " \ > > > + --to=nobody@example.com \ > > > + --thread \ > > > + --nochain-reply-to \ > > > + $patches $patches | > > > + grep "In-Reply-To: " > > > +' > > > > Thanks, but this is not a very good style, as it won't catch if "git > > send-email" dumps core or otherwise fails, exiting with a non-zero status. > > > > Same comments applies to [PATCH 4/6] as well. > > OK, this was my first attempt in writing a test and I just used the last > test 'in-reply-to but no threading' as template. > > What can be done to make the test better? Is this change sufficient? Dumping the stdout into a file and grepping this. t/t9001-send-email.sh | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index ce26ea4..8f810ab 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -621,4 +621,15 @@ test_expect_success 'in-reply-to but no threading' ' grep "In-Reply-To: " ' +test_expect_failure 'threading but no chain-reply-to' ' + git send-email \ + --dry-run \ + --from="Example " \ + --to=nobody@example.com \ + --thread \ + --nochain-reply-to \ + $patches $patches >stdout && + grep "In-Reply-To: " stdout +' + test_done -- 1.6.3.2.220.gb421