From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Mon, 08 Jun 2009 05:47:17 GMT
Subject: Re: [PATCH 2/6] add a test for git-send-email for threaded mails without chain-reply-to
Message-ID: <200906080747.18233.markus.heidelberg@web.de>
In-Reply-To: <7v7hznaaji.fsf@alter.siamese.dyndns.org>

Junio C Hamano, 08.06.2009:
> Markus Heidelberg <markus.heidelberg@web.de> writes:
> 
> > +test_expect_failure 'threading but no chain-reply-to' '
> > +	git send-email \
> > +		--dry-run \
> > +		--from="Example <nobody@example.com>" \
> > +		--to=nobody@example.com \
> > +		--thread \
> > +		--nochain-reply-to \
> > +		$patches $patches |
> > +	grep "In-Reply-To: "
> > +'
> 
> Thanks, but this is not a very good style, as it won't catch if "git
> send-email" dumps core or otherwise fails, exiting with a non-zero status.
> 
> Same comments applies to [PATCH 4/6] as well.

OK, this was my first attempt in writing a test and I just used the last
test 'in-reply-to but no threading' as template.

What can be done to make the test better?