From: Thomas Rast <trast@student.ethz.ch>
Date: Sat, 06 Jun 2009 22:27:41 GMT
Subject: Re: [PATCH v2 3/3] Use die_errno() instead of die() when checking syscalls
Message-ID: <200906070027.44136.trast@student.ethz.ch>
In-Reply-To: <200906062302.08616.j6t@kdbg.org>

Johannes Sixt wrote:
> > @@ -2262,7 +2262,6 @@ int cmd_blame(int argc, const char **argv, const char
> > *prefix)
> >
> >  	if (revs_file && read_ancestry(revs_file))
> >  		die_errno("reading graft file '%s' failed", revs_file);
> > -
> >  	if (cmd_is_annotate) {
> >  		output_option |= OUTPUT_ANNOTATE_COMPAT;
> >  		blame_date_mode = DATE_ISO8601;
> 
> Unrelated and not an improvement.

I used an Emacs macro to turn the die(..., strerror(errno)) [that I
had from v1] into die_errno, and obviously something went terribly
wrong _and_ I missed it.  Sorry :-(

I'll make a new version tomorrow.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch