From: Johannes Sixt <j6t@kdbg.org>
Date: Sat, 06 Jun 2009 21:17:22 GMT
Subject: Re: [PATCH v2 1/3] Introduce die_errno() that appends strerror(errno) to die()
Message-ID: <200906062317.22172.j6t@kdbg.org>
In-Reply-To: <200906062256.34074.trast@student.ethz.ch>

On Samstag, 6. Juni 2009, Thomas Rast wrote:
> Johannes Sixt wrote:
> > On Samstag, 6. Juni 2009, Thomas Rast wrote:
> > > +
> > > +	va_end(params);
> >
> > This va_end should better be before die().
>
> Not that I object to changing it, but out of curiosity, what do I
> break by putting it after?

I don't know, and I suspect that in practice nothing breaks. It's just a 
matter of style: va_start acquires a "resource", and va_end releases it, and 
you should do that as soon as possible after the "resource" is no longer 
needed.

-- Hannes