From: Johannes Sixt <j6t@kdbg.org>
Date: Sat, 06 Jun 2009 20:36:42 GMT
Subject: Re: [PATCH v2 1/3] Introduce die_errno() that appends strerror(errno) to die()
Message-ID: <200906062236.42858.j6t@kdbg.org>
In-Reply-To: <3672f22723a4c14c4a6d67278e9865424c0c68dc.1244299302.git.trast@student.ethz.ch>

On Samstag, 6. Juni 2009, Thomas Rast wrote:
> +void die_errno(const char *err, ...)
> +{
> +	va_list params;
> +	char msg[1024];
> +
> +	va_start(params, err);
> +
> +	vsnprintf(msg, sizeof(msg), err, params);
> +	die("%s: %s", msg, strerror(errno));

Cannot vsnprintf potentially modify errno?

> +
> +	va_end(params);

This va_end should better be before die().

-- Hannes