From: Ben Jackson <ben@ben.com>
Date: Mon, 01 Jun 2009 17:49:44 GMT
Subject: Re: [PATCH 2/2] Add 'git svn reset' to unwind 'git svn fetch'
Message-ID: <20090601174943.GA80846@kronos.home.ben.com>
In-Reply-To: <1243732627-82282-2-git-send-email-ben@ben.com>

On Sat, May 30, 2009 at 06:17:07PM -0700, Ben Jackson wrote:
> Add a command to unwind the effects of fetch by moving the rev_map
> and refs/remotes/git-svn back to an old SVN revision.

I just realized this morning that I didn't do any special handling for
bad revision input.  I will submit a revised patch.  In the mean time
I would still like feedback on the concept and the docs.

Known issues:

1.  Garbage revision input is accepted and prints several internal errors
before bombing out.  The repo is not harmed, though.

2.  Huge revision numbers cause git-svn to spin for quite a while because
I used the pre-existing find_rev_before which is a linear search.

3.  Without --parent it should probably fail for a nonexistent rev rather
than automatically find_rev_before..

-- 
Ben Jackson AD7GD
<ben@ben.com>
http://www.ben.com/