From: Karl Hasselström <kha@treskal.com>
Date: Tue, 19 May 2009 10:27:43 GMT
Subject: Re: [StGit PATCH v2] Add a --set-tree flag to stg push
Message-ID: <20090519102743.GA11135@diana.vm.bytemark.co.uk>
In-Reply-To: <20090519093506.22242.59442.stgit@krank>

On 2009-05-19 11:35:48 +0200, David Kågedal wrote:

> +    opt('--set-tree', action = 'store_true',
> +        short = 'Push the patch with the original tree', long = """
> +        Push the patches, but don't perform a merge. Instead, the
> +        resulting tree will be identical to the tree that the patch
> +        previously created. This can be useful when splitting a patch

Paragraph break after "created"?

> +        by first popping the patch and creating a new patch with some
> +        of the changes. Pushing the original patch with --set-tree
> +        will avoid conflicts and only the remaining changes will be in

The long description is fed to asciidoc, which will translate -- to an
en dash if I recall correctly. The long descriptions of other
commands' flags enclose flags in single quotes.

> +        the patch.
> +        """)

Unnecessary line break.

Apart from those nitpicks,

Acked-by: Karl Hasselström <kha@treskal.com>

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle