From: Jeff King Date: Fri, 08 May 2009 07:45:07 GMT Subject: Re: [RFC/PATCH] Prettify log decorations even more Message-ID: <20090508074507.GF12989@coredump.intra.peff.net> In-Reply-To: <1241649948-11765-1-git-send-email-felipe.contreras@gmail.com> On Thu, May 07, 2009 at 01:45:48AM +0300, Felipe Contreras wrote: > -extern const char *prettify_ref(const struct ref *ref); > +extern const char *prettify_refname(const char *refname); > +#define prettify_ref(ref) prettify_refname((ref)->name) I think it is an improvement for this function to take just the name, but I don't see much point in keeping the crufty #define compatibility. I would just fix up the few callers, as it really is just s/ref/ref->name/. -Peff