From: Robin Rosenberg Date: Sun, 03 May 2009 08:05:57 GMT Subject: Re: [JGIT PATCH 1/2] Ensure that a PackFile instance stays invalid when overwritten Message-ID: <200905031005.57638.robin.rosenberg.lists@dewire.com> In-Reply-To: <1241296230-19342-1-git-send-email-spearce@spearce.org> > @@ -339,6 +351,8 @@ synchronized boolean endWindowCache() { > > private void doOpen() throws IOException { > try { > + if (invalid) > + throw new PackMismatchException("Pack checksum mismatch"); That /may/ be the case. We no longer know why the index failed to open. One way is to save the reason, the other is not to be so d** sure and use a less specific message. -- robin