From: Johannes Sixt <j6t@kdbg.org>
Date: Sat, 25 Apr 2009 18:50:10 GMT
Subject: Re: [PATCH v2] Add an option not to use link(src, dest) && unlink(src) when that is unreliable
Message-ID: <200904252050.10306.j6t@kdbg.org>
In-Reply-To: <7vbpqkznjs.fsf@gitster.siamese.dyndns.org>

On Samstag, 25. April 2009, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > It seems that accessing NTFS partitions with ufsd (at least on my EeePC)
> > has an unnerving bug: if you link() a file and unlink() it right away,
> > the target of the link() will have the correct size, but consist of NULs.
> >
> > It seems as if the calls are simply not serialized correctly, as
> > single-stepping through the function move_temp_to_file() works
> > flawlessly.
> >
> > As ufsd is "Commertial software" (sic!), I cannot fix it, and have to
> > work around it in Git.
> >
> > At the same time, it seems that this fixes msysGit issues 222 and 229 to
> > assume that Windows cannot handle link() && unlink().
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > Acked-by: Johannes Sixt <j6t@kdbg.org>
>
> Hannes, are you ok with this?

Yes. We have been using rename() instead of link() on Windows until recently 
anyway (until link() was implemented, 7be401e06, 2009-01-24). There is no 
regression to be expected from this side.

-- Hannes