From: Jeff King <peff@peff.net>
Date: Thu, 23 Apr 2009 16:40:09 GMT
Subject: Re: [PATCH 1/2] remote.c: silently tolerate single-level keys like remote.default
Message-ID: <20090423164008.GA26346@coredump.intra.peff.net>
In-Reply-To: <1240494546-25775-1-git-send-email-j6t@kdbg.org>

On Thu, Apr 23, 2009 at 03:49:05PM +0200, Johannes Sixt wrote:

> Typos in configuration keys usually do not hurt because they never match
> in look-ups. But this case is different: it does match, but it does not
> have the expected format. With this patch this situation is treated more
> like a typo.

I definitely think causing the command to fail is bad, but should we
perhaps still warn the user? I know that we can't catch _every_ typo in
the config, but if there is something obviously wrong that we've
detected, it is nice to let the user know.

> -		return error("Config with no key for remote %s", name);
> +		return 0;

IOW,

  + warn("Config with no key for remote %s", name);
  + return 0;

-Peff