From: Allan Caffee Date: Wed, 22 Apr 2009 19:38:38 GMT Subject: Re: [PATCH] graph API: fix extra space during pre_commit_line state Message-ID: <20090422193838.GA1841@linux.vnet> In-Reply-To: <87y6tt2wuq.fsf@iki.fi> On Wed, 22 Apr 2009, Teemu Likonen wrote: > On 2009-04-21 14:34 (-0400), Allan Caffee wrote: > > > An extra space is being inserted between the "commit" column and all of > > the successive edges. Remove this space. This regression was > > introduced by 427fc5b. > > > > Signed-off-by: Allan Caffee > > Looks like it's working now, thanks. Let's Cc to Junio so that he > doesn't miss the fix. Actually, Junio, please disregard this patch for the moment. I'll resend it in a series along with another minor fix related to octopus merges. > > This issue exposes a gap in the existing test coverage, which doesn't > > exercise the pre_commit_line code. Maybe another patch is in order to > > extend t4202-log to cover pre-commit lines and octopus merges. > > I think that's a good idea. I like "log --graph" very much and when > someone alters that part of the code I run my own visual "test suites" > to notice if my pet feature has been broken. :-) Automatic tests would > be helpful. I'll include a test patch in that series as well.