From: Jeff King Date: Wed, 22 Apr 2009 19:14:39 GMT Subject: Re: Removing duplicated code between builtin-send-pack.c and transport.c Message-ID: <20090422191439.GA13646@coredump.intra.peff.net> In-Reply-To: On Wed, Apr 22, 2009 at 02:13:28PM -0500, Andy Lester wrote: >> I don't know if that is quite appropriate. I think the point of moving >> many of the duplicated functions into transport.c is that they are used >> by other transports, like http. So probably the transport-agnostic ones >> should stay in transport.c, and they should all get called in the same >> way, no matter what the transport. > > My mistake. I'll remove the code from builtin-send-pack.c, improve it, > and builtin-send-pack.c can get deprecated when/if anyone wants. That makes sense. Thanks. -Peff