From: Jeff King Date: Tue, 21 Apr 2009 02:00:22 GMT Subject: Re: [PATCH RFC3.5 05/12] send-email: Improve redability and error-handling in send_message's sendmail code Message-ID: <20090421020021.GA14479@coredump.intra.peff.net> In-Reply-To: <7vfxg4nl0e.fsf@gitster.siamese.dyndns.org> On Sun, Apr 19, 2009 at 06:58:57PM -0700, Junio C Hamano wrote: > >> + (my $pid = open my $pipe, '|-') > >> + // die "Could not fork to run '$smtp_server': $!\n"; > > > > Have I already rejected this "5.10 or later" construct in the previous > > round? If I haven't, please consider now I have. > > Sorry, I should have checked myself. defined-or "//" is 5.8.1 or later. I don't think that's right. perl581delta lists it in the "Future Directions" section and says A new operator "//" (defined-or) _will_ be available. (emphasis mine). I don't think it was in a stable version until 5.10 (where it is listed as "now this is available" in perl5100delta. Which puts it squarely in the "too new to use" list. -Peff