From: Shawn O. Pearce <spearce@spearce.org>
Date: Fri, 17 Apr 2009 15:16:45 GMT
Subject: Re: [JGIT PATCH 3/3] Extracted AWT-independent superclass from DefaultSshSessionFactory
Message-ID: <20090417151645.GQ23604@spearce.org>
In-Reply-To: <85647ef50904160711w6fbcfcedk2b9a9e1740a4ddd3@mail.gmail.com>

Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:
> The part of DefaultSshSessionFactory that does not depend on
> AWT was refactored to the super class SshConfigSessionFactory.
> The parts of DefaultSshSessionFactory that were used only by
> the OpenSshConfig class were moved to that class.
> 
> Signed-off-by: Constantine Plotnikov <constantine.plotnikov@gmail.com>

Thanks. I applied this, but with a couple of style nitpicks corrected.

> --- a/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java
> @@ -95,6 +97,9 @@ public static OpenSshConfig get() {
>  	/** Cached entries read out of the configuration file. */
>  	private Map<String, Host> hosts;
> 
> +	/** IANA assigned port number for SSH. */
> +	static final int SSH_PORT = 22;
> +

Static constants should be at the top of the class, not after the
instance members.

-- 
Shawn.