From: Jeff King Date: Wed, 15 Apr 2009 07:53:52 GMT Subject: Re: [PATCH v2] Fix buffer overflow in config parser Message-ID: <20090415075352.GB23332@coredump.intra.peff.net> In-Reply-To: <20090415075035.GA23332@coredump.intra.peff.net> On Wed, Apr 15, 2009 at 03:50:35AM -0400, Jeff King wrote: > 2. Tests which happen to require perl as part of the testing. > [...] > Your usage falls into (2), none of which are marked (and if they are to > be marked, then all of them should be, since there is otherwise no > point). I meant to add: it is still nice to avoid the use of perl in the test scripts if we can (and I think we can in this instance, as other responses have noted). If a patch were made to skip tests which use perl, then the fewer tests we have to skip, the better. -Peff