From: Björn Steinbrink Date: Sat, 11 Apr 2009 14:07:56 GMT Subject: Re: [PATCH] process_{tree,blob}: Remove useless xstrdup calls Message-ID: <20090411140756.GA15288@atjola.homenet> In-Reply-To: <20090411134112.GA1673@atjola.homenet> On 2009.04.11 15:41:12 +0200, Björn Steinbrink wrote: > On 2009.04.10 18:15:26 -0700, Linus Torvalds wrote: > > It obviously goes on top of my previous patch. > > Gives some nice results for the "rev-list --all --objects" test on the > gentoo repo says (with the old pack): And for completeness, here are the results for linux-2.6.git | With my patch | With your patch on top -----|---------------|----------------------- VSZ | 460376 | 407900 RSS | 292996 | 239760 time | 0:14.28 | 0:14.66 And again, the new pack is slightly worse than the old one (window=250, --depth=250). Old: 240238406 New: 240280452 But again, it's negligible. Björn