From: Jeff King <peff@peff.net>
Date: Thu, 09 Apr 2009 08:31:15 GMT
Subject: Re: [PATCH] Allow setting default diff options via diff.defaultOptions
Message-ID: <20090409083115.GA17622@coredump.intra.peff.net>
In-Reply-To: <alpine.GSO.2.00.0904081741410.15657@kiwi.cs.ucla.edu>

On Wed, Apr 08, 2009 at 05:44:29PM -0700, Keith Cascio wrote:

> Hi.  Was my last message understandable or should I add more explanation?
>   http://comments.gmane.org/gmane.comp.version-control.git/115506

Your point made sense to me, and is the expected difference between the
two approaches (as we discussed before).

I'm sorry I haven't had a chance to review your patch in detail. It is
pleasantly much shorter than previous iterations, but I wanted to very
carefully check a few of the diff callsites to make sure they work
properly (e.g., some of the cases I laid out earlier in the thread).

I have a lot of regular life responsibilities right now, but I'll try
take a close look this weekend.

-Peff